Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBM-1474 - Swap AWS s3 v1 with v2 #1083

Merged
merged 39 commits into from
Feb 24, 2025
Merged

PBM-1474 - Swap AWS s3 v1 with v2 #1083

merged 39 commits into from
Feb 24, 2025

Conversation

veceraj
Copy link
Collaborator

@veceraj veceraj commented Jan 22, 2025 •
edited
Loading

PR for https://perconadev.atlassian.net/browse/PBM-1474

This PR migrates the AWS S3 SDK from version 1 to version 2.

  • Updated all S3 operations to align with v2
  • Implemented a custom retryer that wraps the v2 standard retryer (note: v2's MaxAttempts includes the first try, so +1 is applied to match v1 behavior) and enforces a minimum backoff.
  • Mapped legacy debugLogLevels to their new AWS SDK v2 equivalents (documentation updated in PBM-1474 Updated the description of DebugLogLevel param pbm-docs#249)
  • Maintained backward compatibility for existing configuration options.

Breaking changes:

  • This PR currently breaks GCS integration, which is being re-implemented as part of PBM-1474

@veceraj veceraj changed the title Pbm-1474 Swap AWS s3 v1 -> v2 SDK API PBM-1474 - Swap AWS s3 v1 with v2 Jan 23, 2025
@veceraj veceraj marked this pull request as ready for review January 26, 2025 22:14
@veceraj veceraj requested a review from boris-ilijic as a code owner January 26, 2025 22:14
boris-ilijic
boris-ilijic reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@boris-ilijic boris-ilijic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, please do the cleanup related to GCS handling.
Beside that I am submitting some other suggestions from first part of the review, let's incorporate all and then I'll finalize review.

@boris-ilijic boris-ilijic self-requested a review February 6, 2025 10:29
boris-ilijic
boris-ilijic reviewed Feb 6, 2025
View reviewed changes
@veceraj veceraj requested a review from boris-ilijic February 18, 2025 11:15
@veceraj veceraj merged commit a9691ec into dev Feb 24, 2025
20 of 21 checks passed
@veceraj veceraj deleted the PBM-1474-aws-s3-migration branch February 24, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-ilijic boris-ilijic boris-ilijic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veceraj @boris-ilijic